Common Knowledge Edits doing something weird
ConversazioniBug Collectors
Iscriviti a LibraryThing per pubblicare un messaggio.
1elahrairah
When I try and put something in a Common Knowledge box it looks like it works and then when the page gets refreshed the box now reads whatever the help text under the box used to read. Here's an example:
https://www.librarything.com/work/15103958
I am unable to delete these because any attempt to edit a Common Knowledge box results in this result.
Is this a me issue or a you issue do you think?
https://www.librarything.com/work/15103958
I am unable to delete these because any attempt to edit a Common Knowledge box results in this result.
Is this a me issue or a you issue do you think?
2kristilabrie
This seems to be a bug.
I'm getting the following error, testing on Chrome/Mac:
Uncaught TypeError: fieldElement.intAttr is not a function
at Object.lt.fwiki.edit (cac4dcbce79f1b52d2dae85b167c0a59.js:657)
at HTMLElement. (cac4dcbce79f1b52d2dae85b167c0a59.js:714)
at HTMLElement.dispatch (jquery-1.8.0.min.js:2)
at HTMLElement.h (jquery-1.8.0.min.js:2)
Steps to reproduce:
1. go to https://www.librarything.com/work/15103958
2. scroll down to the CK section
3. click the edit pencil button to open the canonical title field for editing - see that it fails (bug 1)
4. double click on the field to edit the canonical title field: make sure you don't click on the blue, highlighted text but in the blank text space in the field. note the field opens for editing and turns to a yellow background.
5. select then delete all text in the field then enter, "test" in the field.
6. click "Save" beneath the field to save your entry.
7. "test" is saved in the field, and the background of the field remains yellow.
8. refresh the page.
9. the canonical title field text is back to "Authoritative title for a work in the language of the site you are onSaveCancelHistory", which is in blue text linked to https://www.librarything.com/commonknowledge/search.php?q=Authoritative+title+fo... (bug 2).
I'm getting the following error, testing on Chrome/Mac:
Uncaught TypeError: fieldElement.intAttr is not a function
at Object.lt.fwiki.edit (cac4dcbce79f1b52d2dae85b167c0a59.js:657)
at HTMLElement. (cac4dcbce79f1b52d2dae85b167c0a59.js:714)
at HTMLElement.dispatch (jquery-1.8.0.min.js:2)
at HTMLElement.h (jquery-1.8.0.min.js:2)
Steps to reproduce:
1. go to https://www.librarything.com/work/15103958
2. scroll down to the CK section
3. click the edit pencil button to open the canonical title field for editing - see that it fails (bug 1)
4. double click on the field to edit the canonical title field: make sure you don't click on the blue, highlighted text but in the blank text space in the field. note the field opens for editing and turns to a yellow background.
5. select then delete all text in the field then enter, "test" in the field.
6. click "Save" beneath the field to save your entry.
7. "test" is saved in the field, and the background of the field remains yellow.
8. refresh the page.
9. the canonical title field text is back to "Authoritative title for a work in the language of the site you are onSaveCancelHistory", which is in blue text linked to https://www.librarything.com/commonknowledge/search.php?q=Authoritative+title+fo... (bug 2).
3xaagmabag
I was able to replicate this bug in an author page:
https://www.librarything.com/author/yongamos
Date of birth now says:
"YYYY-MM-DD", "YYYY" "YYYY-MM-DD BCE", "5th-6th c. BCE",Save+ Add itemCancel
https://www.librarything.com/author/yongamos
Date of birth now says:
"YYYY-MM-DD", "YYYY" "YYYY-MM-DD BCE", "5th-6th c. BCE",Save+ Add itemCancel
4jonsweitzerlamme
I'm also having this issue with publication dates.
https://www.librarything.com/work/23804166/book/174340504
and
https://www.librarything.com/work/4806251/book/174311356
https://www.librarything.com/work/23807679/book/174384108
https://www.librarything.com/work/23804166/book/174340504
and
https://www.librarything.com/work/4806251/book/174311356
https://www.librarything.com/work/23807679/book/174384108
5Rivendell
This may be related. In author common knowledge I'm unable to enter edit mode for any field (i.e. nothing happens if I click on the pencil). I'm using Chrome as my browser.
6kristilabrie
Okay, this should now be fixed I believe! If not please wait a few more minutes before re-testing. If anything is still broken, please post here.
7PlaidStallion
Questo membro è stato sospeso dal sito.
8DuncanHill
>7 PlaidStallion: Same happens with the character description box on character pages, you get a tiny box with room for only one line.
Edit: I use Edge on Win10, in case that's relevant.
Edit: I use Edge on Win10, in case that's relevant.
9PlaidStallion
Questo membro è stato sospeso dal sito.
10lilithcat
>7 PlaidStallion:, >8 DuncanHill:
This is happening with the disambiguation field as well.
I'm using MacOS Sierra, tried it with Firefox as well as Safari, and it's the same problem with both.
This is happening with the disambiguation field as well.
I'm using MacOS Sierra, tried it with Firefox as well as Safari, and it's the same problem with both.
11waltzmn
>7 PlaidStallion:
The Common Knowledge edit boxes for quotations default only to one line. Noticed it in the past few days. And you have to drag the box to get multiline. And when you edit a multi-line comment, the text does not wraparound. Behaviour seems to happen on any multi-line box, such a book description. I use Windows 10 Edge browser.
I can confirm this problem on a Macintosh using FireFox. And it's a real problem. I just had to enter an epigraph that was five lines long, and a first sentence that was about three. I made a typo in the first, and because it was near the end, it was almost impossible to fix.
I shudder to think what would happen if I'd been entering, say, the first sentence of the Biblical Book of Ephesians, where the whole first chapter is one sentence. (In the Greek, of course. English translations tend to add punctuation that isn't there. :-)
The Common Knowledge edit boxes for quotations default only to one line. Noticed it in the past few days. And you have to drag the box to get multiline. And when you edit a multi-line comment, the text does not wraparound. Behaviour seems to happen on any multi-line box, such a book description. I use Windows 10 Edge browser.
I can confirm this problem on a Macintosh using FireFox. And it's a real problem. I just had to enter an epigraph that was five lines long, and a first sentence that was about three. I made a typo in the first, and because it was near the end, it was almost impossible to fix.
I shudder to think what would happen if I'd been entering, say, the first sentence of the Biblical Book of Ephesians, where the whole first chapter is one sentence. (In the Greek, of course. English translations tend to add punctuation that isn't there. :-)
12PlaidStallion
Questo membro è stato sospeso dal sito.
13kristilabrie
>7 PlaidStallion: and >11 waltzmn: Can either of you give me a link to your example/s I can easily work from, here, to get a list of reproducible steps for the developers? Thank you!
14waltzmn
>13 kristilabrie:
>7 PlaidStallion: PlaidStallion: and >11 waltzmn: waltzmn: Can either of you give me a link to your example/s I can easily work from, here, to get a list of reproducible steps for the developers? Thank you!
It's happened in every CK page I've seen, but the one that gave me the most trouble was the epigraph for Bloody Williamson: A Chapter in American Lawlessness by Paul M. Angle.
https://www.librarything.com/work/794745/commonknowledge/206065637
Edit the epigraph. Or the First Words, but it's more of a problem in the epigraph.
I also had the problem in the First Words of The Story of Naomi Wise and the History of Randleman, N.C.:
https://www.librarything.com/work/21077078/commonknowledge/205996075
I worked on that one three days ago, I believe.
FWIW, I did not have the problem about a week ago when I did CK for Beyond Lewis & Clark: The Army Explores the West, https://www.librarything.com/work/369011/commonknowledge/205872616
However, when I go there now, I have the problem with the First Words.
I believe the change occurred some time between three and five days ago.
The reproducible step would be to go to CK for ANY book. (Or at least any book that's obscure enough for me to own it. :-p) Edit the Epigraph, Dedication, or First Words, and try to put in something longer than a single line of text.
The edit boxes are ALWAYS one line tall and do not expand. This is fine for people and places and events (I don't know if they even have the problem), but it is very difficult for the Epigraph (usually long), the Dedication (sometimes long), the first words (occasionally long). Probably Quotations and Last Words have problems, too, although I don't usually do CK edits on those.
>7 PlaidStallion: PlaidStallion: and >11 waltzmn: waltzmn: Can either of you give me a link to your example/s I can easily work from, here, to get a list of reproducible steps for the developers? Thank you!
It's happened in every CK page I've seen, but the one that gave me the most trouble was the epigraph for Bloody Williamson: A Chapter in American Lawlessness by Paul M. Angle.
https://www.librarything.com/work/794745/commonknowledge/206065637
Edit the epigraph. Or the First Words, but it's more of a problem in the epigraph.
I also had the problem in the First Words of The Story of Naomi Wise and the History of Randleman, N.C.:
https://www.librarything.com/work/21077078/commonknowledge/205996075
I worked on that one three days ago, I believe.
FWIW, I did not have the problem about a week ago when I did CK for Beyond Lewis & Clark: The Army Explores the West, https://www.librarything.com/work/369011/commonknowledge/205872616
However, when I go there now, I have the problem with the First Words.
I believe the change occurred some time between three and five days ago.
The reproducible step would be to go to CK for ANY book. (Or at least any book that's obscure enough for me to own it. :-p) Edit the Epigraph, Dedication, or First Words, and try to put in something longer than a single line of text.
The edit boxes are ALWAYS one line tall and do not expand. This is fine for people and places and events (I don't know if they even have the problem), but it is very difficult for the Epigraph (usually long), the Dedication (sometimes long), the first words (occasionally long). Probably Quotations and Last Words have problems, too, although I don't usually do CK edits on those.
15kristilabrie
>14 waltzmn: Great, that's all I needed! And yeah, that's not good. Even if you manually expand the box the text is still not wrapping properly.
For developers:
1. Go to https://www.librarything.com/work/794745/summary/206065637
2. Scroll down to the CK section.
3. Click to edit the "Epigraph" field.
Bug: The text is not getting wrapped on more than one line, even if you expand the text box manually.
For developers:
1. Go to https://www.librarything.com/work/794745/summary/206065637
2. Scroll down to the CK section.
3. Click to edit the "Epigraph" field.
Bug: The text is not getting wrapped on more than one line, even if you expand the text box manually.
16kristilabrie
Okay, this should be fixed! Please let me know if you're still having any issues with this. Thanks to conceptDawg.
17waltzmn
>16 kristilabrie:
Okay, this should be fixed! Please let me know if you're still having any issues with this. Thanks to conceptDawg.
Looks good so far! Thanks to both you and conceptDawg.
Okay, this should be fixed! Please let me know if you're still having any issues with this. Thanks to conceptDawg.
Looks good so far! Thanks to both you and conceptDawg.
18PlaidStallion
Questo membro è stato sospeso dal sito.