Works are stuck with wrong member-uploaded covers

Flagged member-uploaded covers are never removed from work pages. Covers continue to show with the wrong work after the flag voting is "closed".

https://www.librarything.com/helpers_covers.php#

>1 aspirit:

This is a long-standing issue and is one of the reasons many of us stopped bothering to flag covers.

2016: https://www.librarything.com/topic/235359
2017: https://www.librarything.com/topic/261557
2012: https://www.librarything.com/topic/146439

>2 lilithcat: I know, but it was bothering me I couldn't find a bug report to point to. Every mention that comes up in search is in Talk About LibraryThing, Flaggers!, Combiners, or in bug reports for an author images (fixed).

Thank you for providing the links. I think those will be useful for clarifying what this is about.

>2 lilithcat: I guess they did finally fix the seals on the beach?

https://blog.librarything.com/main/category/covers/

"Members have long been able to flag cover images that are not valid covers for a given work, by voting “yes” or “no” on an individual cover. Now those flags really matter—covers with enough flags can’t be chosen as the main cover for a work. Like this picture of some seals on a beach, which is definitely not a cover.*
* Covers will be flagged down if:
Vote “yes” totals at least 4.
Vote “yes” totals at least 3x vote “no”.

Tim also says in the 2015 discussion of that post, "First, I need to start removing covers that flunk a vote." https://www.librarything.com/topic/195462#5267868

(HOLLOW LAUGH at the idea that having all the Amazon covers is a great thing....the thousands of wrong covers in my library are now from Amazon yanking or changing covers, and I don't have the time to fix them. Wow, can't believe I brought that up in 2015. https://www.librarything.com/topic/195462#5291790)

Bugged developers about this old bug, again. Thanks for the nudging.

Fleshing this report out a bit more to get clarification (for myself, as well).

First, a section of the "Flagging images" rules here: https://wiki.librarything.com/index.php/Contributing_photos_to_LibraryThing

Voting

Threshhold: At present, an answer meets the threshold if "yes" votes total at least 3X as many "no" votes, and if "yes" votes total at least 4.

Removed: Removed pictures have reached the threshold for yes votes. Removed images do not show up anywhere outside of the flagged picture gallery.

Digging into this bug to find a reproducible report for timspalding, I went to https://www.librarything.com/helpers_covers.php * and looked at the "closed" pages of covers/votes. I'm seeing mostly Amazon covers, which, to my knowledge (per https://www.librarything.com/topic/143873#5221972), don't "do" anything yet.

I did find a live example of a member-uploaded cover that hasn't been removed from the work page yet: https://www.librarything.com/work/23183348/covers (coverid: 11649597).

For devs to reproduce:
1. Go to https://www.librarything.com/helpers_covers.php
2. select to view all "closed" covers/votes
3. click to view page 22 (at the moment; might be moved to a subsequent page as more covers are added)
4. find "One Day at a Time Theme" in the list. There are now 6 "yes" votes and 0 "no" votes (I just voted as the 6th).
5. vote "yes" on the cover flag: AFAIK, cover flag votes should be calculated immediately.

Bug: cover is still showing on work's cover page https://www.librarything.com/work/23183348/covers

*NB: I'm seeing Array text on the top of all of the cover flag sections: All | not yet voted | already voted | closed

I added a seventh.

Unfortunately, flagging pictures doesn't do a thing (anytime, anywhere, ever).

Some of us still work on that "feature", but essentially it's a waste of time.

Most recent very annoying example: Angelina Ballerina, 1,777 members, shows a member-uploaded cover, used exactly once, for Geraldine‘s Blanket, which doesn‘t even hide as a stray copy (I searched very carefully!) … There are, as of now, 5 yes votes and 0 no votes, so not „closed“, but still - how did recalculating go this badly, with 18 member-uploaded and 20 Amazon-covers available?

>8 Nicole_VanK: That's what I'm trying to help get fixed, now. AFAIK, Amazon cover flags don't "do" anything yet (I can certainly understand the frustration here), but it should be working for member-uploaded covers. That's what I'm hoping we can fix for those that need it.

Okay, anyone who doesn't mind helping: can you check to see if you're finding issues with "closed" cover flag votes? This includes Amazon and member-uploaded covers.

Here's one that's strange:

https://www.librarything.com/work/10734498/covers

The main cover is a flagged "best-guess image" cover of a Penguin Popular Edition, not the movie that this entry represents.
But: that wrong cover isn't even showing up on the page with Cover Images, where 2 correct member-uploaded and 3 correct Amazon covers are available - the winning main cover isn't even available to select.

Vote count: Yes 8, No 0.

>12 leselotte: that is a weird one, thanks. Seeing if timspalding has any idea about it.

Another similar one:

https://www.librarything.com/work/19555433/covers

The winning cover is flagged (Yes 4, No 0), again a "best-guess"-image. There's one correct member-uploaded cover available, used only once, though, and no Amazon covers.
But, as with the previously mentioned title, the winning cover is not available to select on the Change Cover page.

Okay, 12 and 14 are fixed. Thanks.